From 182ff2f63571af0efe1551b3a873cdf5e21707a6 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Wed, 27 May 2026 18:17:08 +0000 Subject: [PATCH] Remove duplicate Object.defineProperty loop in headless Terminal The constructor defined property getters/setters twice on _publicOptions; the first block was immediately overwritten by the second. Align with the browser public Terminal implementation. Fixes #5935 Co-authored-by: Daniel Imms --- src/headless/public/Terminal.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/headless/public/Terminal.ts b/src/headless/public/Terminal.ts index 0d4e6e93b..093ae7909 100644 --- a/src/headless/public/Terminal.ts +++ b/src/headless/public/Terminal.ts @@ -40,15 +40,6 @@ export class Terminal extends Disposable implements ITerminalApi { }; for (const propName in this._core.options) { - Object.defineProperty(this._publicOptions, propName, { - get: () => { - return this._core.options[propName]; - }, - set: (value: any) => { - this._checkReadonlyOptions(propName); - this._core.options[propName] = value; - } - }); const desc = { get: getter.bind(this, propName), set: setter.bind(this, propName)