From ed03dad8de553b023b198606d52b6d968ad57b39 Mon Sep 17 00:00:00 2001 From: Dave Cheney Date: Fri, 8 Aug 2014 11:42:28 +1000 Subject: [PATCH] go.crypto/ssh/test: skip tests during -short mode This proposal effectively disables all the ssh/test tests when run with the -short flag supplied. For developers and users of this package, there should be no change unless they are in the habbit of always supplying -short, which I belive is untrue. For the CI dashboard the effect should be that these tests, which are really not portable enough to run reliably on all our various builders, are disabled. LGTM=adg R=adg, agl, hanwen CC=golang-codereviews https://golang.org/cl/125860043 --- ssh/test/test_unix_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ssh/test/test_unix_test.go b/ssh/test/test_unix_test.go index 597ee08..3ac310e 100644 --- a/ssh/test/test_unix_test.go +++ b/ssh/test/test_unix_test.go @@ -224,6 +224,9 @@ func writeFile(path string, contents []byte) { // newServer returns a new mock ssh server. func newServer(t *testing.T) *server { + if testing.Short() { + t.Skip("skipping test due to -short") + } dir, err := ioutil.TempDir("", "sshtest") if err != nil { t.Fatal(err)