From d701c51f7e4e57f61c4947390514fe631e06202f Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Mon, 20 Jul 2026 18:10:27 +0000 Subject: [PATCH] acme: fix nil pointer dereference in pebble test error reporting The WaitOrder failure path used errors.Is with a nil *OrderError target, which never matches and left orderErr nil at the point its Problem field was dereferenced. Use errors.As to populate the target instead. Found by govet's nilness check. Change-Id: Ieef849fcbf04c85ef32651059db2b5fe162af325 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/803181 Reviewed-by: Roland Shoemaker LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com Reviewed-by: Carlos Amedee --- acme/pebble_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acme/pebble_test.go b/acme/pebble_test.go index 79051ac..08dbab4 100644 --- a/acme/pebble_test.go +++ b/acme/pebble_test.go @@ -383,7 +383,7 @@ func testIssuance(t *testing.T, env *environment, challSrv challengeServer) { order, err = client.WaitOrder(ctx, order.URI) if err != nil { var orderErr *acme.OrderError - if errors.Is(err, orderErr) { + if errors.As(err, &orderErr) { t.Fatalf("failed to wait for order %s: %s: %s", orderURL, err, orderErr.Problem) } else { t.Fatalf("failed to wait for order %s: %s", orderURL, err)