From ce1cf546ac92dd001ee433ec58b6b0f9828e1cee Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 25 May 2014 13:56:25 -0700 Subject: [PATCH] go.crypto/hkdf: get rid of appends LGTM=agl R=golang-codereviews, bradfitz, agl CC=golang-codereviews https://golang.org/cl/95370044 --- hkdf/hkdf.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hkdf/hkdf.go b/hkdf/hkdf.go index b20e834..5c6cf6f 100644 --- a/hkdf/hkdf.go +++ b/hkdf/hkdf.go @@ -42,13 +42,11 @@ func (f *hkdf) Read(p []byte) (int, error) { p = p[n:] // Fill the buffer - var input []byte for len(p) > 0 { - input = append(f.prev, f.info...) - input = append(input, f.counter) - f.expander.Reset() - f.expander.Write(input) + f.expander.Write(f.prev) + f.expander.Write(f.info) + f.expander.Write([]byte{f.counter}) f.prev = f.expander.Sum(f.prev[:0]) f.counter++