From b2aa35443fbc700ab74c586ae79b81c171851023 Mon Sep 17 00:00:00 2001 From: Han-Wen Nienhuys Date: Tue, 3 Apr 2018 10:00:15 +0200 Subject: [PATCH] ssh: drop extra connection Close call in TestMuxReadWrite The extra Close call runs in a separate goroutine, and races with the deferred Close call, leading to test flakes if the extra call fails Change-Id: Ia1a2fb3932906da7cd0a8854b55f82785bb33716 Reviewed-on: https://go-review.googlesource.com/104335 Run-TryBot: Han-Wen Nienhuys TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- ssh/mux_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ssh/mux_test.go b/ssh/mux_test.go index 25d2181..d88b64e 100644 --- a/ssh/mux_test.go +++ b/ssh/mux_test.go @@ -108,10 +108,6 @@ func TestMuxReadWrite(t *testing.T) { if err != nil { t.Fatalf("Write: %v", err) } - err = s.Close() - if err != nil { - t.Fatalf("Close: %v", err) - } }() var buf [1024]byte