From 86ce3cb696783b739e41e834e2eead3e1b4aa3fb Mon Sep 17 00:00:00 2001 From: Jason Baker Date: Mon, 10 Feb 2020 22:12:59 +0000 Subject: [PATCH] acme/autocert: fix TLS-ALPN identifier in tests CL 204177 broke autocert tests because they expected the old OID. Fixes golang/go#37160 Change-Id: Id732d4d249bbe5107fa0a3ba4829012600d8a52d GitHub-Last-Rev: 77e8d1ff0072866d8466c56885d01d3b91d5baef GitHub-Pull-Request: golang/crypto#117 Reviewed-on: https://go-review.googlesource.com/c/crypto/+/218941 Reviewed-by: Filippo Valsorda Run-TryBot: Filippo Valsorda TryBot-Result: Gobot Gobot --- acme/autocert/autocert_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/acme/autocert/autocert_test.go b/acme/autocert/autocert_test.go index 74d1397..f08d800 100644 --- a/acme/autocert/autocert_test.go +++ b/acme/autocert/autocert_test.go @@ -488,9 +488,8 @@ func startACMEServerStub(t *testing.T, tokenCert getCertificateFunc, domain stri if err := crt.VerifyHostname(domain); err != nil { t.Errorf("verifyTokenCert: %v", err) } - // TODO: Update OID to the latest value 1.3.6.1.5.5.7.1.31 // See https://tools.ietf.org/html/draft-ietf-acme-tls-alpn-05#section-5.1 - oid := asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 1, 30, 1} + oid := asn1.ObjectIdentifier{1, 3, 6, 1, 5, 5, 7, 1, 31} for _, x := range crt.Extensions { if x.Id.Equal(oid) { // No need to check the extension value here.