diff --git a/.github/workflows/external-plugin-rereview.yml b/.github/workflows/external-plugin-rereview.yml index ceaff7bc..1cf07459 100644 --- a/.github/workflows/external-plugin-rereview.yml +++ b/.github/workflows/external-plugin-rereview.yml @@ -233,7 +233,7 @@ jobs: ...unmatchedRows ].join('\n') : '', - ].filter(Boolean).join('\n'); + ].join('\n'); if (existingTrackerIssues.length > 0) { const [primary, ...duplicates] = existingTrackerIssues; diff --git a/.github/workflows/skill-check-comment.yml b/.github/workflows/skill-check-comment.yml index 95be2bc2..7c27c243 100644 --- a/.github/workflows/skill-check-comment.yml +++ b/.github/workflows/skill-check-comment.yml @@ -214,7 +214,7 @@ jobs: exitCode !== '0' ? '> **Note:** The validator returned a non-zero exit code. Please review the findings above before merge.' : '', - ].filter(Boolean).join('\n'); + ].join('\n'); // Find existing comment with our marker const { data: comments } = await github.rest.issues.listComments({ diff --git a/eng/external-plugin-intake.mjs b/eng/external-plugin-intake.mjs index d41c19cd..b767082b 100644 --- a/eng/external-plugin-intake.mjs +++ b/eng/external-plugin-intake.mjs @@ -553,7 +553,7 @@ function buildMergedIntakeComment(baseResult, qualityResult, runId, owner, repo) ? ["", "### Warnings", "", ...baseResult.warnings.map((warning) => `- ${warning}`)].join("\n") : "", runLink ? `\n${runLink}` : "", - ].filter(Boolean).join("\n"); + ].join("\n"); } export function applyQualityGateResult(baseEvaluation, qualityGateResult, runId, owner, repo) { @@ -644,7 +644,7 @@ export async function evaluateExternalPluginIssue({ issue, token, runId, owner, ? ["", "### Warnings", "", ...dedupedWarnings.map((warning) => `- ${warning}`)].join("\n") : "", runLink ? `\n${runLink}` : "", - ].filter(Boolean).join("\n") + ].join("\n") : [ marker, "## ❌ External plugin intake failed", @@ -659,7 +659,7 @@ export async function evaluateExternalPluginIssue({ issue, token, runId, owner, ? ["", "### Warnings", "", ...dedupedWarnings.map((warning) => `- ${warning}`)].join("\n") : "", runLink ? `\n${runLink}` : "", - ].filter(Boolean).join("\n"); + ].join("\n"); return { valid,