From fb5e0f561fe96950a39ca72e6d67c12df88cc2f2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 9 Jun 2026 05:09:03 +0000 Subject: [PATCH] chore: publish from staged --- .github/workflows/external-plugin-rerun-intake-command.yml | 7 +++++++ CONTRIBUTING.md | 2 +- eng/external-plugin-intake.mjs | 5 +++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/external-plugin-rerun-intake-command.yml b/.github/workflows/external-plugin-rerun-intake-command.yml index 2d15bdb3..1ae6dc78 100644 --- a/.github/workflows/external-plugin-rerun-intake-command.yml +++ b/.github/workflows/external-plugin-rerun-intake-command.yml @@ -100,6 +100,13 @@ jobs: return; } + await github.rest.reactions.createForIssueComment({ + owner: context.repo.owner, + repo: context.repo.repo, + comment_id: context.payload.comment.id, + content: 'eyes' + }); + const baseResult = await intake.evaluateExternalPluginIssue({ issue: currentIssue, token: process.env.GITHUB_TOKEN, diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1107f04b..4c0cf9b2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -235,7 +235,7 @@ The public-submission policy builds on those rules and also requires `license` p - install smoke test via Copilot CLI against an ephemeral marketplace entry generated from the submission 4. **Ready for maintainer review**: if metadata validation and quality gates pass, automation removes `awaiting-review` and adds `ready-for-review`. 5. **Submitter-fix blocker**: if metadata is valid but quality gates fail, automation applies `requires-submitter-fixes` instead of advancing to human review. -6. **Requesting another intake pass**: after updating the issue body or source plugin, the issue author or a maintainer can comment `/rerun-intake` to re-run automated intake and quality gates on demand. Open issues still re-trigger intake automatically on edit, but closed rejected issues need `/rerun-intake`. +6. **Requesting another intake pass**: after updating the issue body or source plugin, the issue author or a maintainer can comment `/rerun-intake` to re-run automated intake and quality gates on demand. Open issues still re-trigger intake automatically on edit, but closed rejected issues need `/rerun-intake`. When the rerun is accepted, automation reacts to the command comment with 👀 so it is visible that processing started. 7. **Maintainer override path**: a maintainer with write access can comment `/mark-ready-for-review [optional reason]` to explicitly move a `requires-submitter-fixes` issue to `ready-for-review`. 8. **Maintainer decision**: once in `ready-for-review`, a maintainer with write access performs the manual review, then comments `/approve` or `/reject ` on the issue. Commands from non-maintainers are ignored. 9. **Approval path**: on `/approve`, automation removes `ready-for-review`, adds `approved`, closes the issue, and opens or updates a PR against `staged` that updates `plugins/external.json` and generated marketplace outputs. diff --git a/eng/external-plugin-intake.mjs b/eng/external-plugin-intake.mjs index c51b9b38..c3e50083 100644 --- a/eng/external-plugin-intake.mjs +++ b/eng/external-plugin-intake.mjs @@ -460,8 +460,10 @@ function buildMergedIntakeComment(baseResult, qualityResult, runId, owner, repo) "", qualitySection, "", + "", "### Canonical external.json payload", "", + "", "```json", JSON.stringify(baseResult.plugin ?? {}, null, 2), "```", @@ -546,12 +548,15 @@ export async function evaluateExternalPluginIssue({ issue, token, runId, owner, parsed.plugin.source.sha ? `- **SHA:** ${parsed.plugin.source.sha}` : undefined, `- **Keywords:** ${normalizedKeywords}`, "", + "", "### Canonical external.json payload", "", + "", payload, "", "### Reviewer notes", "", + "", notes, dedupedWarnings.length > 0 ? ["", "### Warnings", "", ...dedupedWarnings.map((warning) => `- ${warning}`)].join("\n")