From e8d8a79c8e2aa16bda2848da36ec5f03b20c441e Mon Sep 17 00:00:00 2001 From: Ashley Childress <6563688+anchildress1@users.noreply.github.com> Date: Thu, 15 Jan 2026 22:54:56 -0500 Subject: [PATCH] ci(contributors): simplify contributor check using step outcome - Replace brittle grep check with exit code-based branching - Use continue-on-error and conditional report generation Generated-by: GitHub Copilot Signed-off-by: Ashley Childress <6563688+anchildress1@users.noreply.github.com> --- .github/workflows/contributors.yml | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/.github/workflows/contributors.yml b/.github/workflows/contributors.yml index 6f2dc6eb..7588b8b6 100644 --- a/.github/workflows/contributors.yml +++ b/.github/workflows/contributors.yml @@ -32,22 +32,19 @@ jobs: - name: Install dependencies run: npm ci - - name: Check and report contributors + - name: Check contributors + id: contributors_check + run: npm run contributors:check + env: + PRIVATE_TOKEN: ${{ secrets.GITHUB_TOKEN }} + continue-on-error: true + + - name: Generate contributors report + if: steps.contributors_check.outcome == 'failure' run: | - CHECK_OUTPUT=$(npm run contributors:check 2>&1) - echo "$CHECK_OUTPUT" - - if echo "$CHECK_OUTPUT" | grep -q "Missing contributors"; then - echo "Missing contributors detected, generating report..." - mkdir -p reports - npm run contributors:report - - if [ -f reports/contributor-report.md ]; then - cat reports/contributor-report.md >> $GITHUB_STEP_SUMMARY - fi - else - echo "No missing contributors found" - fi + mkdir -p reports + npm run contributors:report + test -f reports/contributor-report.md && cat reports/contributor-report.md >> "$GITHUB_STEP_SUMMARY" env: PRIVATE_TOKEN: ${{ secrets.GITHUB_TOKEN }} continue-on-error: true