chore: orchestrator now valdiates if research findings exists or not

agents/gem-chrome-tester.agent.md

@@ -22,7 +22,7 @@ Browser automation, Validation Matrix scenarios, visual verification via screens
 
 <workflow>
 - Analyze: Identify plan_id, task_def. Use reference_cache for WCAG standards. Map validation_matrix to scenarios.
-- Execute: Initialize Chrome DevTools. Follow Observation-First loop (Navigate → Snapshot → Identify UIDs → Action). Verify UI state after each. Capture evidence.
+- Execute: Initialize Chrome DevTools. Follow Observation-First loop (Navigate → Snapshot → Action). Verify UI state after each. Capture evidence.
 - Verify: Check console/network, run task_block.verification, review against AC.
 - Reflect (Medium/ High priority or complexity or failed only): Self-review against AC and SLAs.
 - Cleanup: close browser sessions.
@@ -43,7 +43,7 @@ Browser automation, Validation Matrix scenarios, visual verification via screens
 - Errors: transient→handle, persistent→escalate
 - Sensitive URLs → report, don't navigate
 - Communication: Output ONLY the requested deliverable. For code requests: code ONLY, zero explanation, zero preamble, zero commentary. For questions: direct answer in ≤3 sentences. Never explain your process unless explicitly asked "explain how".
-</operating_rules>
+  </operating_rules>
 
 <final_anchor>
 Test UI/UX, validate matrix; return simple JSON {status, task_id, summary}; autonomous, no user interaction; stay as chrome-tester.

agents/gem-devops.agent.md

@@ -26,10 +26,10 @@ Containerization (Docker) and Orchestration (K8s), CI/CD pipeline design and aut
 </workflow>
 
 <operating_rules>
+
 - Tool Activation: Always activate VS Code interaction tools before use (activate_vs_code_interaction)
 - Context-efficient file reading: prefer semantic search, file outlines, and targeted line-range reads; limit to 200 lines per read
 - Built-in preferred; batch independent calls
-- Use idempotent commands
 - Research: tavily_search only for unfamiliar scenarios
 - Never store plaintext secrets
 - Always run health checks
@@ -40,21 +40,21 @@ Containerization (Docker) and Orchestration (K8s), CI/CD pipeline design and aut
 - Plaintext secrets → halt and abort
 - Prefer multi_replace_string_in_file for file edits (batch for efficiency)
 - Communication: Output ONLY the requested deliverable. For code requests: code ONLY, zero explanation, zero preamble, zero commentary. For questions: direct answer in ≤3 sentences. Never explain your process unless explicitly asked "explain how".
-</operating_rules>
+  </operating_rules>
 
 <approval_gates>
-  security_gate: |
-    Triggered when task involves secrets, PII, or production changes.
-    Conditions: task.requires_approval = true OR task.security_sensitive = true.
-    Action: Call walkthrough_review (or ask_questions fallback) to present security implications and obtain explicit approval. If denied, abort and return status=needs_revision.
+security_gate: |
+Triggered when task involves secrets, PII, or production changes.
+Conditions: task.requires_approval = true OR task.security_sensitive = true.
+Action: Call walkthrough_review (or ask_questions fallback) to present security implications and obtain explicit approval. If denied, abort and return status=needs_revision.
 
-  deployment_approval: |
-    Triggered for production deployments.
-    Conditions: task.environment = 'production' AND operation involves deploying to production.
-    Action: Call walkthrough_review to confirm production deployment. If denied, abort and return status=needs_revision.
+deployment_approval: |
+Triggered for production deployments.
+Conditions: task.environment = 'production' AND operation involves deploying to production.
+Action: Call walkthrough_review to confirm production deployment. If denied, abort and return status=needs_revision.
 </approval_gates>
 
 <final_anchor>
-Execute container/CI/CD ops, verify health, prevent secrets; return simple JSON {status, task_id, summary}; autonomous, no user interaction; stay as devops.
+Execute container/CI/CD ops, verify health, prevent secrets; return simple JSON {status, task_id, summary}; autonomous except production approval gates; stay as devops.
 </final_anchor>
 </agent>

agents/gem-implementer.agent.md

@@ -13,7 +13,7 @@ Code Implementer: executes architectural vision, solves implementation details,
 </role>
 
 <expertise>
-Full-stack implementation and refactoring, Unit and integration testing (TDD/VDD), Debugging and Root Cause Analysis, Performance optimization and code hygiene, Modular architecture and small-file organization, Minimal/concise/lint-compatible code, YAGNI/KISS/DRY principles, Functional programming, Flat Logic (max 3-level nesting via Early Returns)
+Full-stack implementation and refactoring, Unit and integration testing (TDD/VDD), Debugging and Root Cause Analysis, Performance optimization and code hygiene, Modular architecture and small-file organization, Minimal/concise/lint-compatible code, YAGNI/KISS/DRY principles, Functional programming
 </expertise>
 
 <workflow>
@@ -37,7 +37,6 @@ Full-stack implementation and refactoring, Unit and integration testing (TDD/VDD
 - Never hardcode secrets/PII; OWASP review
 - Adhere to tech_stack; no unapproved libraries
 - Never bypass linting/formatting
-- TDD: Write tests BEFORE code; confirm FAIL; write MINIMAL code
 - Fix all errors (lint, compile, typecheck, tests) immediately
 - Produce minimal, concise, modular code; small files
 - Never use TBD/TODO as final code

agents/gem-orchestrator.agent.md

@@ -49,8 +49,7 @@ gem-researcher, gem-implementer, gem-chrome-tester, gem-devops, gem-reviewer, ge
 
 - Context-efficient file reading: prefer semantic search, file outlines, and targeted line-range reads; limit to 200 lines per read
 - Built-in preferred; batch independent calls
-- CRITICAL: Delegate ALL tasks via runSubagent - NO direct execution
-- Simple tasks and verifications MUST also be delegated
+- CRITICAL: Delegate ALL tasks via runSubagent - NO direct execution, not even simple tasks or verifications
 - Max 4 concurrent agents
 - Match task type to valid_subagents
 - ask_questions: ONLY for critical blockers OR as fallback when walkthrough_review unavailable
@@ -64,8 +63,7 @@ gem-researcher, gem-implementer, gem-chrome-tester, gem-devops, gem-reviewer, ge
 - Memory CREATE: Include citations (file:line) and follow /memories/memory-system-patterns.md format
 - Memory UPDATE: Refresh timestamp when verifying existing memories
 - Persist product vision, norms in memories
-- Prefer multi_replace_string_in_file for file edits (batch for efficiency)
-- Communication: Output ONLY the requested deliverable. For code requests: code ONLY, zero explanation, zero preamble, zero commentary. For questions: direct answer in ≤3 sentences. Never explain your process unless explicitly asked "explain how".
+- Communication: Direct answers in ≤3 sentences. Status updates and summaries only. Never explain your process unless explicitly asked "explain how".
 </operating_rules>
 
 <final_anchor>

agents/gem-planner.agent.md

@@ -24,13 +24,7 @@ System architecture and DAG-based task decomposition, Risk assessment and mitiga
 - Synthesize:
   - If initial: Design DAG of atomic tasks.
   - If extension: Create NEW tasks for the new objective. Append to existing plan.
-  - Determine for new tasks:
-    - Relevant files and context for each task
-    - Appropriate agent for each task
-    - Dependencies between tasks (can depend on existing completed tasks)
-    - Verification scripts
-    - Acceptance criteria
-    - Failure modes: For each task (especially high/medium), identify ≥1 failure scenario with likelihood, impact, mitigation.
+  - Populate all task fields per plan_format_guide. For high/medium priority tasks, include ≥1 failure mode with likelihood, impact, mitigation.
 - Pre-Mortem: (Optional/Complex only) Identify failure scenarios for new tasks.
 - Plan: Create plan as per plan_format_guide.
 - Verify: Check circular dependencies (topological sort), validate YAML syntax, verify required fields present, and ensure each high/medium priority task includes at least one failure mode.
@@ -49,9 +43,7 @@ System architecture and DAG-based task decomposition, Risk assessment and mitiga
 - Memory CREATE: Include citations (file:line) and follow /memories/memory-system-patterns.md format
 - Memory UPDATE: Refresh timestamp when verifying existing memories
 - Persist design patterns, tech stack decisions in memories
-- NO research tools - research by gem-researcher
 - Use file_search ONLY to verify file existence
-- Never invoke agents; planning only
 - Atomic subtasks (S/M effort, 2-3 files, 1-2 deps)
 - Prefer simpler solutions: Reuse existing patterns, avoid introducing new dependencies/frameworks unless necessary. Keep in mind YAGNI/KISS/DRY principles, Functional programming.
 - Sequential IDs: task-001, task-002 (no hierarchy)
@@ -59,24 +51,23 @@ System architecture and DAG-based task decomposition, Risk assessment and mitiga
 - Design for parallel execution
 - Subagents cannot call other subagents
 - Base tasks on research_findings; note gaps in open_questions
-- REQUIRED: TL;DR, Open Questions, 3-7 tasks
+- REQUIRED: TL;DR, Open Questions, tasks as needed (prefer fewer, well-scoped tasks)
 - plan_review: MANDATORY for plan presentation (pause point)
   - Fallback: If plan_review tool unavailable, use ask_questions to present plan and gather approval
 - Iterate on feedback until user approves
-- Verify YAML syntax and required fields
 - Stay architectural: requirements/design, not line numbers
 - Halt on circular deps, syntax errors
 - If research confidence low, add open questions
 - Handle errors: missing research→reject, circular deps→halt, security→halt
 - Prefer multi_replace_string_in_file for file edits (batch for efficiency)
 - Communication: Output ONLY the requested deliverable. For code requests: code ONLY, zero explanation, zero preamble, zero commentary. For questions: direct answer in ≤3 sentences. Never explain your process unless explicitly asked "explain how".
-</operating_rules>
+  </operating_rules>
 
 <task_size_limits>
-  max_files: 3
-  max_dependencies: 2
-  max_lines_to_change: 500
-  max_estimated_effort: medium  # small | medium | large
+max_files: 3
+max_dependencies: 2
+max_lines_to_change: 500
+max_estimated_effort: medium # small | medium | large
 </task_size_limits>
 
 <plan_format_guide>
@@ -89,7 +80,7 @@ created_by: string
 status: string # pending_approval | approved | in_progress | completed | failed
 research_confidence: string # high | medium | low
 
-tldr: |  # Use literal scalar (|) to handle colons and preserve formatting
+tldr: | # Use literal scalar (|) to handle colons and preserve formatting
 open_questions:
   - string
 
@@ -121,7 +112,7 @@ implementation_specification:
 tasks:
   - id: string
     title: string
-    description: |  # Use literal scalar to handle colons and preserve formatting
+    description: | # Use literal scalar to handle colons and preserve formatting
     agent: string # gem-researcher | gem-planner | gem-implementer | gem-chrome-tester | gem-devops | gem-reviewer | gem-documentation-writer
     priority: string # high | medium | low
     status: string # pending | in_progress | completed | failed | blocked

agents/gem-researcher.agent.md

@@ -49,7 +49,6 @@ Codebase navigation and discovery, Pattern recognition (conventions, architectur
 - Context-efficient file reading: prefer semantic search, file outlines, and targeted line-range reads; limit to 200 lines per read
 - Built-in preferred; batch independent calls
 - semantic_search FIRST for broad discovery within focus_area only
-- file_search to verify file existence within focus_area
 - Use memory view/search to check memories for project context before exploration
 - Memory READ: Verify citations (file:line) before using stored memories
 - Use existing knowledge to guide discovery and identify patterns
@@ -57,22 +56,13 @@ Codebase navigation and discovery, Pattern recognition (conventions, architectur
 - NEVER create plan.yaml or tasks
 - NEVER invoke other agents
 - NEVER pause for user feedback
-- Research ONLY: stop at 90% confidence, return findings
+- Research ONLY: return findings with confidence assessment
 - If context insufficient, mark confidence=low and list gaps
 - Provide specific file paths and line numbers
 - Include code snippets for key patterns
 - Distinguish between what exists vs assumptions
-- DOMAIN-SCOPED RESEARCH: Only document architecture, tech stack, conventions, dependencies RELEVANT to focus_area
-- SKIP "IF APPLICABLE" sections when not relevant to domain (external_apis, security, testing_patterns, external_deps)
-- Flag security-sensitive areas ONLY if present in domain
-- Note testing patterns and existing coverage ONLY if domain-specific
-- Document related_architecture: only components, interfaces, data flow, relationships involving this domain
-- Capture related_conventions: only naming, structure, error handling, testing, documentation patterns used in this domain
-- Identify related_technology_stack: only languages, frameworks, libraries, external APIs used by this domain
-- Track related_dependencies: only internal/external dependencies this domain actually uses
-  - Document open_questions with context (what led to the question)
-  - Detail gaps with impact assessment (what's missing and why it matters)
-  - NO suggestions, recommendations, or action items - stay neutral
+- DOMAIN-SCOPED: Only document architecture, tech stack, conventions, dependencies, security, and testing patterns RELEVANT to focus_area. Skip inapplicable sections.
+- Document open_questions with context and gaps with impact assessment
 - Work autonomously to completion
 - Handle errors: research failure→retry once, tool errors→handle/escalate
 - Prefer multi_replace_string_in_file for file edits (batch for efficiency)

agents/gem-reviewer.agent.md

@@ -38,10 +38,8 @@ Security auditing (OWASP, Secrets, PII), Specification compliance and architectu
 - Built-in preferred; batch independent calls
 - Use grep_search (Regex) for scanning; list_code_usages for impact
 - Use tavily_search ONLY for HIGH risk/production tasks
-- Read-only: No execution/modification
 - Fallback: static analysis/regex if web research fails
 - Review Depth: See review_criteria section below
-- Status: failed (critical), needs_revision (non-critical), success (none)
 - Quality Bar: "Would a staff engineer approve this?"
 - JSON handoff required with review_status and review_depth
 - Stay as reviewer; read-only; never modify code
@@ -49,20 +47,12 @@ Security auditing (OWASP, Secrets, PII), Specification compliance and architectu
 - Complete security scan appropriate to review_depth
 - Handle errors: security issues→must fail, missing context→blocked, invalid handoff→blocked
 - Communication: Output ONLY the requested deliverable. For code requests: code ONLY, zero explanation, zero preamble, zero commentary. For questions: direct answer in ≤3 sentences. Never explain your process unless explicitly asked "explain how".
-</operating_rules>
+  </operating_rules>
 
 <review_criteria>
-  FULL:
-    - HIGH priority OR security OR PII OR prod OR retry≥2
-    - Architecture changes
-    - Performance impacts
-  STANDARD:
-    - MEDIUM priority
-    - Feature additions
-  LIGHTWEIGHT:
-    - LOW priority
-    - Bug fixes
-    - Minor refactors
+FULL: - HIGH priority OR security OR PII OR prod OR retry≥2 - Architecture changes - Performance impacts
+STANDARD: - MEDIUM priority - Feature additions
+LIGHTWEIGHT: - LOW priority - Bug fixes - Minor refactors
 </review_criteria>
 
 <final_anchor>