From 49d020f31ab5772ff3034270ebf8ac0222fb40c2 Mon Sep 17 00:00:00 2001
From: Aaron Powell <me@aaron-powell.com>
Date: Wed, 8 Jul 2026 12:34:05 +1000
Subject: [PATCH] Fix kanban refresh error exposure (#2242)

Stop the accessibility kanban extension from persisting raw refresh failure details to browser-visible state. Use a generic safe error message for clients, clear any previously persisted detailed refresh errors during state normalization, and keep detailed diagnostics server-side via console logging.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---
 extensions/accessibility-kanban/extension.mjs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/extensions/accessibility-kanban/extension.mjs b/extensions/accessibility-kanban/extension.mjs
index e5cf760a..777f205a 100644
--- a/extensions/accessibility-kanban/extension.mjs
+++ b/extensions/accessibility-kanban/extension.mjs
@@ -11,6 +11,7 @@ const EXTENSION_NAME = "accessibility-kanban";
 const STATE_FILE_PREFIX = "repository-issues-kanban-state";
 const COLUMNS = ["backlog", "plan", "ready", "implement", "done"];
 const VALID_COLUMNS = new Set(COLUMNS);
+const REFRESH_ISSUES_ERROR = "Unable to refresh issues right now. Please try again.";
 
 let repoInfoCache = null;
 let githubTokenCache;
@@ -197,7 +198,7 @@ function normalizeState(rawState, repoInfo = getRepoInfo()) {
 
   return {
     repo,
-    error: repoInfo.error || rawState?.error || null,
+    error: repoInfo.error || (rawState?.error === REFRESH_ISSUES_ERROR ? REFRESH_ISSUES_ERROR : null),
     updatedAt: rawState?.updatedAt || new Date().toISOString(),
     generation: rawState?.generation || Date.now(),
     columns: Array.isArray(rawState?.columns) && rawState.columns.length ? rawState.columns : COLUMNS,
@@ -453,9 +454,10 @@ async function refreshIssuesSafe() {
     broadcast("state", merged);
     return merged;
   } catch (error) {
+    console.error("[accessibility-kanban] Failed to refresh issues", error);
     const failed = {
       ...state,
-      error: error instanceof Error ? error.message : String(error),
+      error: REFRESH_ISSUES_ERROR,
     };
     saveState(failed);
     broadcast("state", failed);